This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] add selected-frame-level-changed events


On Tue, 27 Aug 2002, Andrew Cagney wrote:


Why not put it in there anyway?

You mean add a notification in select_frame? Because UIs don't care when GDB is temporarily switching frames for whatever reason. What matters is when something happens to cause the current frame to be changed and cause gdb and the MI client to get out of sync. As far as I know, this only happens via the command line frame commands (up, down, frame). There might be others, but I've never seen them.
Wonder what the TUI gets up to :-)

I think, not putting it in select_frame() is the part that needs the fixme.

Right, that's what I meant. Sorry if I was vague. Ideally, we would like it in select_frame, but we cannot do that right now because the UI would be informed of billions of frame changes per step, especially if varobj is operating.
Ok. Can you just add comments explaining the above, especially in select_frame(), so that people know why the call isn't yet there.

As for the unnecessary select frame calls, I guess ``we'' are working on it. I suspect that varobj could do with an audit --- use FRAME_ID() and frame parameterized versions of various functions.

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]