This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] i386nbsd_pc_in_sigtramp robustness
- From: Mark Kettenis <kettenis at chello dot nl>
- To: Jason R Thorpe <thorpej at wasabisystems dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: 02 Sep 2002 23:39:05 +0200
- Subject: Re: [PATCH] i386nbsd_pc_in_sigtramp robustness
- References: <20020902093426.G4034@dr-evil.shagadelic.org>
Jason R Thorpe <thorpej@wasabisystems.com> writes:
> --3xoW37o/FfUZJwQG
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
>
> The strategy of comparing against hard-coded addresses to find the
> signal trampoline is a bad one; it is possible for the user to change
> the VM layout, and thus the location of the signal trampoline, with a
> kernel option.
>
> The following patch changes the i386-netbsd* targets to disassemble to
> find the trampoline, as is done for other NetBSD targets.
Just a few thoughts:
* Doesn't this break things for NetBSD before 1.4? Did you consider
falling back on the old method?
* Did you notice any effect on performance? Reading from a target's
memory can be time-consuming for remote targets.
Mark