This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC/A] gdb/680: ui_out_reset?
On Sep 11, 12:15pm, Keith Seitz wrote:
> In this case, the register commands (and probably a lot of other commands,
> too) are just plain programmed wrong. They should be using
> make_cleanup_ui_out_list/tuple_begin_end instead of
> ui_out_list/tuple_begin and ui_out_list/tuple_end.
>
> How's this patch look? It doesn't cause an regressions and fixes gdb/680.
> Keith
>
> ChangeLog
> 2002-09-11 Keith Seitz <keiths@redhat.com>
>
> * mi-main.c (mi_cmd_data_list_register_names): Use cleanups
> for the uiout list. Do the cleanups when returning an error.
> (mi_cmd_data_list_changed_registers): Ditto.
> (mi_cmd_data_list_register_values): Use cleanups for the uiout list
> and tuples. Do the cleanups when returning errors.
Looks good to me.
(Since this is also the approach that I took, I'll commit my patches
too.)
Kevin