This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Finding source files under cygwin


On Mon, Sep 16, 2002 at 12:06:56PM -0700, Earl Chew wrote:
>Christopher Faylor wrote:
>> >Another fix is to make source.c use ; (semicolon) as a path
>> >separator instead of : (colon) should HAVE_DOS_BASED_FILE_SYSTEM
>> >be true. The downside here is that it might be surprising
>> >to current cygwin users.
>> 
>> This one is out.  This would break backwards compatibility and would be
>> incompatible with the convention used in the rest of cygwin.
>> 
>> The simplest solution is to just compile your object files using
>> the /cygdrive/d/xxx/yyy/zzz syntax.  The ability to use this syntax
>> is one of the motivations for cygwin.
>> 
>> However, if you want to provide a patch for either open_source_file
>> or buildsym.c, I'll gladly review it.
>
>I've included a patch below for you to consider. In addition to
>robustly handling the presence of DIRNAME_SEPARATOR in the file
>names embedded in the object file, I've included a patch to allow
>files to be found in source trees.
>
>The motivation for this addition is to accommodate large projects
>where source files are scattered in large source trees. I want to
>be able to point gdb at the root of the source tree, rather than have
>to specify each leaf directory. Thus I can write:
>
>	gdb> dir /myproject/source
>
>instead of:
>
>	gdb> dir /myproject/source/a/b/c:/myproject/source/z/b/d: etc

I'm sorry but it is rarely a good idea to mix functionality like this.
You're mixing an (arguable) bug fix with an (arguable) gdb enhancement.

Please submit each as a separate patch.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]