This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Multi-arch i386 instruction printing


Mark Kettenis wrote:
This patch multi-arch's i386 instruction printing.  In doing so I took
a somewhat different approach than what's done for other targets, by
always overriding the disassemble_info fields that the i386
instruction printer cares about.

Seems to work fine, and should also be able to handle x86_64.
I propose once again an introdction of i386-common.[ch] (as I already did in eflags register printing thread).

IMHO i386_print_insn() is a perfect candidate to go there, while it's the same on all i386-platforms as well as on x86-64 arch. I believe that more functions finally could go there. What do you think about it?

Michal Ludvig
--
* SuSE CR, s.r.o * mludvig@suse.cz
* +420 2 9654 5373 * http://www.suse.cz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]