This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA:] Typo fixes, dwarf2cfi.c and docs.


Can I have write-after-approval rights?  No admin actions
needed, I think.  Copyright assignment papers are in place.
For "one good patch" to gdb see
<URL:http://sources.redhat.com/ml/gdb-patches/2000-06/msg00120.html>.
The patches below would be covered by the rule of obviousness,
methinks.

Ok to commit?

gdb:
	* dwarf2cfi.c (struct cie_unit): Fix typo in comment.
	(pointer_encoding): Correct function type to static.

gdb/doc:
	* gdb.texinfo (Packets): Fix typos "alligned".
	Correct z3/Z3 description.  Correct z4/Z4 title.

Index: dwarf2cfi.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2cfi.c,v
retrieving revision 1.16
diff -p -c -r1.16 dwarf2cfi.c
*** dwarf2cfi.c	19 Jul 2002 09:40:51 -0000	1.16
--- dwarf2cfi.c	29 Sep 2002 20:27:19 -0000
*************** struct cie_unit
*** 49,55 ****
    /* A constant that is factored out of all offset instructions.  */
    int data_align;

!   /* A constant that indicates which regiter represents the return address
       of a function.  */
    unsigned char ra;

--- 49,55 ----
    /* A constant that is factored out of all offset instructions.  */
    int data_align;

!   /* A constant that indicates which register represents the return address
       of a function.  */
    unsigned char ra;

*************** read_encoded_pointer (bfd * abfd, char *
*** 557,563 ****
   * - encoding & 0x0f : size of the address (handled in read_encoded_pointer())
   * - encoding & 0x70 : type (absolute, relative, ...)
   * - encoding & 0x80 : indirect flag (DW_EH_PE_indirect == 0x80).  */
! enum ptr_encoding
  pointer_encoding (unsigned char encoding)
  {
    int ret;
--- 557,563 ----
   * - encoding & 0x0f : size of the address (handled in read_encoded_pointer())
   * - encoding & 0x70 : type (absolute, relative, ...)
   * - encoding & 0x80 : indirect flag (DW_EH_PE_indirect == 0x80).  */
! static enum ptr_encoding
  pointer_encoding (unsigned char encoding)
  {
    int ret;

Index: doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.124
diff -p -c -r1.124 gdb.texinfo
*** doc/gdb.texinfo	21 Sep 2002 00:29:04 -0000	1.124
--- doc/gdb.texinfo	29 Sep 2002 20:40:06 -0000
*************** Reserved for future use.
*** 15055,15061 ****

  Read @var{length} bytes of memory starting at address @var{addr}.
  Neither @value{GDBN} nor the stub assume that sized memory transfers are
! assumed using word alligned accesses. FIXME: @emph{A word aligned memory
  transfer mechanism is needed.}

  Reply:
--- 15055,15061 ----

  Read @var{length} bytes of memory starting at address @var{addr}.
  Neither @value{GDBN} nor the stub assume that sized memory transfers are
! assumed using word aligned accesses. FIXME: @emph{A word aligned memory
  transfer mechanism is needed.}

  Reply:
*************** Reply:
*** 15063,15069 ****
  @item @var{XX@dots{}}
  @var{XX@dots{}} is mem contents. Can be fewer bytes than requested if able
  to read only part of the data.  Neither @value{GDBN} nor the stub assume
! that sized memory transfers are assumed using word alligned
  accesses. FIXME: @emph{A word aligned memory transfer mechanism is
  needed.}
  @item E@var{NN}
--- 15063,15069 ----
  @item @var{XX@dots{}}
  @var{XX@dots{}} is mem contents. Can be fewer bytes than requested if able
  to read only part of the data.  Neither @value{GDBN} nor the stub assume
! that sized memory transfers are assumed using word aligned
  accesses. FIXME: @emph{A word aligned memory transfer mechanism is
  needed.}
  @item E@var{NN}
*************** for an error
*** 15355,15361 ****
  @cindex @code{z3} packet
  @cindex @code{Z3} packet

! Insert (@code{Z3}) or remove (@code{z3}) a write watchpoint.

  Reply:
  @table @samp
--- 15355,15361 ----
  @cindex @code{z3} packet
  @cindex @code{Z3} packet

! Insert (@code{Z3}) or remove (@code{z3}) a read watchpoint.

  Reply:
  @table @samp
*************** not supported
*** 15367,15374 ****
  for an error
  @end table

! @item @code{z}@code{4}@code{,}@var{addr}@code{,}@var{length} --- remove read watchpoint @strong{(draft)}
! @item @code{Z}@code{4}@code{,}@var{addr}@code{,}@var{length} --- insert read watchpoint @strong{(draft)}
  @cindex @code{z4} packet
  @cindex @code{Z4} packet

--- 15367,15374 ----
  for an error
  @end table

! @item @code{z}@code{4}@code{,}@var{addr}@code{,}@var{length} --- remove access watchpoint @strong{(draft)}
! @item @code{Z}@code{4}@code{,}@var{addr}@code{,}@var{length} --- insert access watchpoint @strong{(draft)}
  @cindex @code{z4} packet
  @cindex @code{Z4} packet

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]