This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Andrew Cagney wrote:
OK. I was not sure, as the code is older than that. But I guess the copyright goes by the file, not the code...Two tweeks:+ /* Disassemble support for GDB. + Copyright 2000, 2001, 2002 Free Software Foundation, Inc. + Contributed by Cygnus Solutions (a Red Hat company).The (C) should just be 2002 and ``Red Hat, Inc.''.
+ This file is part of GDB.
+ + This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2 of the License, or
+ (at your option) any later version.
+ + This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+ + You should have received a copy of the GNU General Public License
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 59 Temple Place - Suite 330,
+ Boston, MA 02111-1307, USA. */
+ + extern void gdb_disassembly (char *file_string,
+ int line_num,
+ int mixed_source_and_assembly,
+ int how_many, CORE_ADDR low, CORE_ADDR high);
It needs #ifdef DISASM_H et.al.
Yes, how could I forget!
It should take an explicit ui_out parameter.
Good point. Of all people I should have remembered that one ;-)
It seems that it may need some clean-up. But you are right, I am just moving code and I like to do the least possible changes on that pass.As for the rest vis:! static int ! gdb_dis_asm_read_memory (bfd_vma memaddr, bfd_byte * myaddr, ! unsigned int len, disassemble_info * info) ! { ! extern struct target_ops exec_ops;
I guess we all get to grit our teeth because we know you're just moving around existing code :-)
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |