This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Interpreters (~final) (fwd)


I am looking more at the branch than at the patch. I am trying to come
up with another way of breaking this down. If I am lucky.

A couple of little things I noticed. More in a bit.

The error messages in interps.c print strings with mi_ in them, like:

 + 	  error
 + 	    ("interpreter-exec: mi_interpreter_execute: error in command: \"%s\".",
 + 	     prules[i]);


The use of wrapper.[ch] is discouraged. Put the necessary safe
functions near where they are used (so we wack 2 files from the list
of stuff to merge). Look at corefile.c:safe_read_memory_integer, for
instance. 

Who uses gdb_delete_interpreter? If it is there "just in case" add a
comment that says so.

I bet more changes are coming down the pipe, but could we tighten the
interfaces a bit. I think some more functions could be made static and
removed from .h files.

Elena





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]