This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH RFA] Create new file mips-tdep.h
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Thu, 3 Oct 2002 22:26:13 -0400
- Subject: Re: [PATCH RFA] Create new file mips-tdep.h
- References: <1021004010349.ZM32674@localhost.localdomain>
On Thu, Oct 03, 2002 at 06:03:49PM -0700, Kevin Buettner wrote:
> I have some other changes under way in which I will need to know which
> mips ABI is in use. I've moved struct gdbarch_tdep and the enums
> that it depends upon into a new header file.
>
> Okay?
I think this is a good idea, though of course you'll need to wait for
Andrew - it may be some time, I believe.
This patch reminded me of something. I don't really like the fact that
we have a "struct gdbarch_tdep" for every architecture; when we have a
multi-architecture GDB this will cause tremendous debugging confusion.
How intrusive do you think it would be to opaquify it (I hope that's
not really a word) properly, and have a struct mips_gdbarch_tdep?
>
> * Makefile.in (mips_tdep_h): Define.
> (mips-tdep.o): Remove osabi_h from dependency list. Add mips_tdep_h
> to dependency list.
> * mips-tdep.h: New file.
> * mips-tdep.c (mips-tdep.h): Include.
> (osabi.h): Don't include (since it's included by mips-tdep.h).
> (enum mips_abi, enum_mips_fpu_type, struct gdbarch_tdep): Move
> definitions to mips-tdep.h.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer