This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/rfc] Remove all setup_xfail's from testsuite/gdb.mi/


Andrew Cagney wrote:

Hello,

GDB's testsuite is known to be full of xfails that are really kfails or
testsuite bugs.  Rather than try to audit each xfail in turn, the
proposal as been to rip out all the xfails (creating a clean slate) and
start marking up the tests from scratch - two steps forward but first
one step back.

I figure I might as well try to get the ball rolling on this and find
out just how much real resistance there is going to be to a change like
this.  To that end, this removes all xfail's from the gdb.mi testsuite.
  Similar tests, for the other directories, would follow.

I don't know if MI is the best choice to start with.
Who's going to fix them up?  Certainly not me.

Why not pick one or two mainstream tests, from gdb.base, that have a lot
of xfails in them.  Let us get a feel for the pain threshold.  Changes
to gdb.mi don't tell me a thing, because I generally ignore it.
True. For the MI though, I know all the existing XFAILs are bogus so I'm in a stronger position to argue that they should be removed anyway. Besides, it appears MI is being worked on at present.

Anyway, it will look like this:

Before:

                === gdb Summary ===

# of expected passes            8298
# of unexpected failures        60
# of unexpected successes       10
# of expected failures          172
# of unsupported tests          2

After:

                === gdb Summary ===

# of expected passes            8308
# of unexpected failures        232
# of unsupported tests          2
Andrew.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]