This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA/Semi-obvious/5.3?] Fix compilation error in hppa-tdep.c
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Joel Brobecker <brobecker at gnat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 30 Oct 2002 09:10:53 -0500
- Subject: Re: [RFA/Semi-obvious/5.3?] Fix compilation error in hppa-tdep.c
- References: <20021030080837.GY903@gnat.com> <20021030082803.GA903@gnat.com>
On Wed, Oct 30, 2002 at 12:28:03AM -0800, Joel Brobecker wrote:
> > 2002-10-30 Joel Brobecker <brobecker@gnat.com>
> >
> > * hppa-tdep.c (find_function_in_inferior): Fix the declaration
> > that caused a compilation error on HP/UX.
> > (low_text_segment_addres): Fix a compilation warning.
>
> Actually, I am replying to myself: the fix to find_function_in_inferior
> works, but is pretty stupid. Better to remove the extern altogether,
> since we get the definition directly from value.h (which caused the
> compilation error in the first place).
>
> Sorry about that, I should not be working that late I suppose.
>
> Here is a new patch, with a new ChangeLog:
>
> 2002-10-30 Joel Brobecker <brobecker@gnat.com>
>
> * hppa-tdep.c (find_function_in_inferior): Remove this extern,
> as this is already provided by value.h, and was actually causing
> a compilation error due to a conflict in parameter type declaration
> due to a missing const keyword.
> (low_text_segment_addres): Fix a compilation warning.
>
> It looks like the 5.3 branch has the same problem, so I'll fix it too
> when I get approval for this patch.
Your patch is correct (and that's a serious warning, too... there was
an actual bug there). With two sets of eyes this is OK to commit,
since HP/UX is currently marked as an OBSOLETE candidate.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer