This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Redefine skip_quoted
- From: Jim Blandy <jimb at redhat dot com>
- To: Adam Fedor <fedor at doc dot com>
- Cc: Elena Zannoni <ezannoni at redhat dot com>, Klee Dienes <klee at apple dot com>, Michael Snyder <msnyder at redhat dot com>, gdb-patches at sources dot redhat dot com
- Date: 07 Nov 2002 15:21:51 -0500
- Subject: Re: [PATCH] Redefine skip_quoted
- References: <95706CBA-DFBC-11D6-A1B6-00039396EEB8@apple.com><vt2fzv6sv3q.fsf@zenia.red-bean.com> <3DAF2C71.6030908@doc.com><15792.33251.884402.152637@localhost.redhat.com><3DB09113.9070205@doc.com>
Adam Fedor <fedor@doc.com> writes:
> > > > > > Well, really the use of skip_quoted for ObjC (in a patch
> > that I haven't > submitted yet), really has more to do with
> > handling the canonical form > of an Objective-C method symbol
> > (e.g. -[MyObject myMethod:arg2:]) that > comes from
> > objc-lang.c. Most of the breakpoint cases that a user would > enter
> > are handled elsewhere (in a patch that I also haven't submitted).
> > > I have to agree with Jim here, I think we should wait on the
> > parts you
> > haven't submitted before deciding on this one. Could you just have
> > added the chars you need to the gdb_completer_word_break_characters
> > variable?
>
> No. It involves removing characters. Another option would be to define
> a new function, say skip_objc_quoted, just for objc which would be
> similar to skip_quoted. How about that?
So, the change would become local to the Objective-C code, right? If
it doesn't hurt the functionality you're trying to provide, that
certainly sounds better to me, at least.