This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa] linespec.c, part 2
- From: Elena Zannoni <ezannoni at redhat dot com>
- To: David Carlton <carlton at math dot stanford dot edu>
- Cc: gdb-patches at sources dot redhat dot com, Elena Zannoni <ezannoni at redhat dot com>, Jim Blandy <jimb at redhat dot com>, Fernando Nasser <fnasser at redhat dot com>
- Date: Mon, 11 Nov 2002 10:37:50 -0500
- Subject: Re: [rfa] linespec.c, part 2
- References: <ro1adkjalf6.fsf@jackfruit.Stanford.EDU>
David Carlton writes:
> Here's part 2 of the linespec patches. This one's quite
> straightforward; it just moves two chunks of code from the beginning
> of decode_line_1 to separate functions initialize_defaults and
> decode_indirect. Also, it turns out that, later in decode_line_1,
> defaults get re-initialized, so I turned that into a second call to
> initialize_defaults.
>
> David Carlton
> carlton@math.stanford.edu
>
> 2002-11-07 David Carlton <carlton@math.stanford.edu>
>
> * linespec.c (decode_line_1): Move chunks of code to separate
> functions.
> (initialize_defaults): New function.
> (decode_indirect): New function.
>
> * (gdb) break foo if (a==b)
> @@ -1034,10 +1015,7 @@ decode_line_1 (char **argptr, int funfir
>
> /* Make sure we have at least a default source file. */
> set_default_source_symtab_and_line ();
Shouldn't this line go too?
struct symtab_and_line cursal;
Othewise OK.
Elena