Re: [Jim Blandy <jimb@redhat.com>] RFA: testsuite: attach.exp: don'tmove executables to /tmp

[Fernando Nasser <fnasser at redhat dot com>]

Jim Blandy wrote:
> Ping on this test suite patch.
Approved.

Thanks for the cleanup.

Regards,
Fernando



> ------------------------------------------------------------------------
>
> Subject:
> RFA: testsuite: attach.exp: don't move executables to /tmp
> From:
> Jim Blandy <jimb@redhat.com>
> Date:
> 21 Nov 2002 00:33:01 -0500
> To:
> gdb-patches@sources.redhat.com
>
>
> 2002-11-21  Jim Blandy  <jimb@redhat.com>
>
> 	* gdb.base/attach.exp: There's no need to copy the test program to
> 	/tmp; that was only ever necessary on HP/UX, and this test is
> 	entirely disabled there anyway.
>
> Index: gdb/testsuite/gdb.base/attach.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/attach.exp,v
> retrieving revision 1.7
> diff -c -r1.7 attach.exp
> *** gdb/testsuite/gdb.base/attach.exp	11 Jul 2002 00:50:34 -0000	1.7
> --- gdb/testsuite/gdb.base/attach.exp	21 Nov 2002 05:47:24 -0000
> ***************
> *** 63,93 ****
>        gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
>   }
>   
> - # Because we can't attach over nfs, copy binfile to /tmp/${binfile}.${pid}
> - # and replace binfile with a symbolic link
> - 
> -   set pid [pid]
> -   exec /bin/cp -f ${binfile} /tmp/attach1.${pid}
> -   exec rm -f ${binfile}
> -   set binfile /tmp/attach1.${pid}
> - #  exec ln -s /tmp/attach1.${pid} ${binfile}
> - 
>   # Build the in-system-call test
>   
>   if  { [gdb_compile "${srcdir}/${subdir}/${srcfile2}" "${binfile2}" executable {debug}] != "" } {
>        gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
>   }
>   
> - # Because we can't attach over nfs, copy binfile2 to /tmp/${binfile2}.${pid}
> - # and replace binfile2 with a symbolic link
> - 
> -   set pid [pid]
> -   exec cp -f ${binfile2} /tmp/attach2.${pid} 
> -   exec rm -f ${binfile2}
> -   set binfile2 /tmp/attach2.${pid}
> - #  exec ln -s /tmp/attach2.${pid} ${binfile2}
> - 
> - 
>   if [get_compiler_info ${binfile}] {
>       return -1
>   }
> --- 63,74 ----
> ***************
> *** 428,446 ****
>   gdb_exit
>   gdb_start
>   
> - # this seems not necessary. - guo
> - #
> - # # Since we have moved the executable to /tmp, it will be hard for gdb
> - # # to find the object file/executable to read the symbols.  This is
> - # # a known limitation.  We try and get the name of the executable the
> - # # process is running from a variety of methods, but none is foolproof.
> - # # Using "dir" will get us the symbols.
> - # 
> - # gdb_test "dir ./gdb.base" ".*" "set up directory before attach"
>   gdb_reinitialize_dir $srcdir/$subdir
>   do_call_attach_tests
> - 
> - # Cleanup the files placed in /tmp and the symlinks
> -   remote_exec build "rm -f ${binfile} ${binfile2} /tmp/attach1.${pid} /tmp/attach2.${pid}"
>   
>   return 0
> --- 409,415 ----

--
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9