This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
PATCH: Remove an error() in stabsread.c
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: gdb-patches at sources dot redhat dot com
- Cc: Raoul Gough <raoulgough at clara dot co dot uk>
- Date: Sun, 5 Jan 2003 00:05:13 -0500
- Subject: PATCH: Remove an error() in stabsread.c
Raoul ran into a demangler bug that triggered this error. The demangler bug
has been separately reported to GCC, but upon rethinking this, a complaint()
is fine here; the problem should disturb nothing except perhaps calls to the
affected method, which is a pretty small problem. So complain about it, but
don't abort symbol reading entirely.
Checked in. Bug fix, but it doesn't affect the 5.3 branch anyway.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
2003-01-04 Daniel Jacobowitz <drow@mvista.com>
* stabsread.c (update_method_name_from_physname): Call complaint()
instead of error.
Index: stabsread.c
===================================================================
RCS file: /cvs/src/src/gdb/stabsread.c,v
retrieving revision 1.47
retrieving revision 1.49
diff -u -p -r1.47 -r1.49
--- stabsread.c 2 Jan 2003 14:27:26 -0000 1.47
+++ stabsread.c 5 Jan 2003 04:59:28 -0000 1.49
@@ -2985,7 +2985,11 @@ update_method_name_from_physname (char *
method_name = method_name_from_physname (physname);
if (method_name == NULL)
- error ("bad physname %s\n", physname);
+ {
+ complaint (&symfile_complaints,
+ "Method has bad physname %s\n", physname);
+ return;
+ }
if (strcmp (*old_name, method_name) != 0)
{