This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa] missing frame_register
- From: David Carlton <carlton at math dot stanford dot edu>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: "gdb-patches at sources dot redhat dot com" <gdb-patches at sources dot redhat dot com>, Andrew Cagney <ac131313 at redhat dot com>
- Date: 17 Mar 2003 13:05:44 -0800
- Subject: Re: [rfa] missing frame_register
- References: <ro11y15g4he.fsf@jackfruit.Stanford.EDU><1047935045.1490.50.camel@lindt.uglyboxes.com>
On 17 Mar 2003 13:04:05 -0800, Keith Seitz <keiths at redhat dot com> said:
> On Mon, 2003-03-17 at 11:47, David Carlton wrote:
> I was hoping not to have to do anything about this until later (let 'em
> sweat for a few hours! :v), but I don't believe the below will work:
>> + frame_register (deprecated_selected_frame, regnum, &optim,
>> + NULL, NULL, &realnum, raw_buffer);
> In frame.c:
> void
> frame_register (struct frame_info *frame, int regnum,
> int *optimizedp, enum lval_type *lvalp,
> CORE_ADDR *addrp, int *realnump, void *bufferp)
> {
> /* Require all but BUFFERP to be valid. A NULL BUFFERP indicates
> that the value proper does not need to be fetched. */
> gdb_assert (optimizedp != NULL);
> gdb_assert (lvalp != NULL);
> gdb_assert (addrp != NULL);
> gdb_assert (realnump != NULL);
> /* gdb_assert (bufferp != NULL); */
Oh. Whoops. I guess I could have done a bit more checking! I guess
I needed a few more dummy variables, or something.
> I have a patch that does work (I think), and I will check it in
> momentarily, unless you want to follow through.
Thanks, be my guest.
> I appreciate your thinking of me, urgh, insight!
Well, I figured I owed insight one after I inadvertently broke it
twice a month or so back.
David Carlton
carlton at math dot stanford dot edu