This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[RFA/hppa] Remove hack in hppa_push_dummy_frame...
- From: Joel Brobecker <brobecker at gnat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Mon, 17 Mar 2003 18:30:08 -0800
- Subject: [RFA/hppa] Remove hack in hppa_push_dummy_frame...
Hello,
A long time ago (that long already), I sent a question asking how to
rework a hack that was currently in place. Andrew looked at the code,
and wondered how it could possibly be working.
The probable answer is: it doesn't! I removed the code in question, and
rerun it through the testsuite, and did not see any regression.
This hack is causing me trouble for the multiarch conversion, and Andrew
mentionned that this was preventing him from making `struct frame_info'
opaque. I therefore suggest that we remove this code at once.
I am sure this code was there for something, and that some problem will
show up later, but I suggest we fix it then, and we fix it the proper
way.
2003-03-17 J. Brobecker <brobecker at gnat dot com>
* hppa-tdep.c (hppa_push_dummy_frame): Remove hack which does not
appear to be working in any case.
The next will then to fix the profile of hppa_push_dummy_frame to remove
the dependency on struct inferior_status (by removing the now-unused
parameter), to make it conformant with the push_dummy_frame gdbarch method.
Ok to apply?
--
Joel