This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] i386-cygwin-tdep.c


Corinna Vinschen <vinschen at redhat dot com> writes:

> I created a patch to allow switching to reg_struct_return for Cygwin.
> According to Andrew's reply on gdb@ I created a new file i386-cygwin-tdep.c
> and added everything needed to get it working.
> 
> Ok to commit?

Hmm, Interix also has a sniffer that detects pei-i386, so installing
this patch rules out having a GDB that supports.  It would be great if
you could find a clever way to distinguish between the two.  However,
in the current state of affairs, with Interix not being in a working
state yet, this patch is fine.  Could you add a comment in
i386_cygwin_osabi_sniffer that Interix also uses pei-i386 and that we
need a way to distinguish between the to?  Consider a patch with that
change pre-approved.

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]