This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Compile objc-lang.c, objc-exp.tab.c [1/5]


On Sun, 30 Mar 2003 19:23:08 -0700, Adam Fedor <fedor at doc dot com> said:

> Here's my crack at doing [language-specific demangling].

This patch bothers me: it doesn't handle Java cleanly, and I'm not
sure about the 'options' argument to language_demangle.  It seems to
me that, at the very least, there should be a java_demangle function
defined that takes the options passed in, applies '| DMGL_JAVA' to it,
and calls cplus_demangle.

But I also wanted to double-check: does 'options' really make sense
for all language types?  If I'm reading the patch correctly, it looks
like Objective C just throws it away.  If that's the case, then I
don't think that 'options' should be part of the language vector: if
C++ needs it for internal purposes, then C++ could have its own more
flexible demangler with that option (which Java could also use), but
the version in the language vector should be more restricted.

David Carlton
carlton at math dot stanford dot edu


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]