This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Remove calls to inside_entry_file



Oh, you wrote "Consider that approved" so I didn't thought I'd have to send it again to gdb-patches. However, what about the important part of my posting:

Yes, just please always post changes.


I've checked in the frame.c patch but still, I don't understand this
decision.  So called out-of-date targets can easily add the
inside_entry_file() call to their frame_chain_valid() implementation
so removing this call from blockframe.c does not necessarily break
them.  Keeping this call in blockframe.c on the other hand breaks
some targets for which this call is plainly wrong.  So the logic would
imply to remove the call in favour of *all* targets able to run correctly.

Per my previous comment, I'd prefer to not touch the old code at all - let it die. Mark, I'll note, already has i386 replacement code in waiting.


The other thing to do is to ask DanielJ if he knows anything more about that specific case.

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]