This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Handle ObjC OPS in eval.c


On Sat, Apr 19, 2003 at 09:42:49PM -0600, Adam Fedor wrote:
> 
> 
> Elena Zannoni wrote:
> >Adam Fedor writes:
> > > 
> > > 
> > > Elena Zannoni wrote:
> > > [...]
> > > > 
> > > > I think we need more comments, I guess stret means structure return?
> > > > What are these methods used for? Also can you add a high level
> > > > description of how these dispatchers get into the picture?
> > > > 
> > > 
> > > Here's a better documented and slightly cleaned-up patch.
> > > 2003-03-04  Adam Fedor  <fedor at gnu dot org>
> >
> >I think it's ok. Except I don't like to introduce more #if0 code with new 
> >code.
> >Do we really need that part?
> >
> 
> I bet no one would complain if I took it out.
> 
> The larger problem I have, though, is changing the patch so that I can 
> call the objc-lang functions indirectly, so that objc-lang.o does not 
> have to be linked in. That seems like a pain.
> 
> I think it would be easier to split objc-lang.c into two parts. One that 
> is architecture independant that I could link in now, and the other 
> acitecture dependant part (which is already handled via the language 
> vector). Anything wrong with that?

What would go in the architecture dependant part?  That shouldn't
involve te _language_ vector, it should involve the _gdbarch_ vector,
and go in the already-existing arch files.  I think.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]