Re: [patch rfc] Deprecate tm_print_insn_info

[Andrew Cagney <ac131313 at redhat dot com>]

> Hello,
>
> This patch cleans up / deprecates:
>
>     tm_print_insn_info
>     TARGET_PRINT_INSN_INFO
>     dis_asm_print_address
>     dis_asm_memory_read
>     dis_asm_memory_error
>
> they are merged into a single:
>
>     deprecated_tm_print_insn_info
>
> that lives in "disasm.c".  It would all be static, with "deprecated_tm_print_insn_info" deleted, if it were not for some accesses that still need eliminating (at least it is now possible to find them).
>
> Note that "printcmd.c" is still using deprecated_tm_print_insn_info instead of gdb_disassemble.  Turns out that further gdb_disassemble fixes are needed - the "sim" target has the same problems as "core", "thread", "procfs", ....  Fix to follow.

I've checked this in.

> Index: ChangeLog
> 2003-04-28  Andrew Cagney  <cagney@redhat.com>
>
> 	* gdbarch.sh (deprecated_tm_print_insn_info): Rename
> 	"tm_print_insn_info".
> 	(TARGET_PRINT_INSN_INFO): Delete macro.
> 	(dis_asm_read_memory): Delete function declaration.
> 	(dis_asm_memory_error, dis_asm_print_address): Ditto.
> 	(tm_print_insn_info): Delete variable definition.
> 	(_initialize_gdbarch): Do not initialize "tm_print_insn_info".
> 	* gdbarch.h, gdbarch.c: Re-generate.
> 	* d10v-tdep.c (display_trace): Replace "tm_print_insn_info" with
> 	"deprecated_tm_print_insn_info".
> 	* mcore-tdep.c (mcore_dump_insn): Ditto.
> 	* mips-tdep.c (mips_gdbarch_init): Ditto.
> 	* sparc-tdep.c (_initialize_sparc_tdep): Ditto.
> 	* v850-tdep.c (v850_scan_prologue, v850_gdbarch_init): Ditto.
> 	* ia64-tdep.c (_initialize_ia64_tdep): Ditto.
> 	* printcmd.c (print_insn): Use "deprecated_tm_print_insn_info"
> 	instead of TARGET_PRINT_INSN_INFO, add comment.
> 	* s390-tdep.c (s390_get_frame_info): Instead of
> 	"dis_asm_read_memory", use "deprecated_tm_print_insn_info".
> 	(s390_check_function_end, s390_is_sigreturn): Ditto.
> 	* corefile.c (dis_asm_read_memory): Move to "disasm.c".
> 	(dis_asm_memory_error, dis_asm_print_address): Ditto.
> 	* disasm.c: Include "gdbcore.h".
> 	(_initialize_disasm): New function, initialize
> 	"deprecated_tm_print_insn_info".
> 	(deprecated_tm_print_insn_info): New variable.
> 	(dis_asm_read_memory): Moved from "corefile.c", made static.
> 	(dis_asm_print_address, dis_asm_memory_error): Ditto.
> 	* Makefile.in (disasm.o): Update dependencies.
>
> Index: gdbtk/ChangeLog
> 2003-04-28  Andrew Cagney  <cagney@redhat.com>
>
> 	* generic/gdbtk-cmds.c (gdb_disassemble_driver): Instead of
> 	TARGET_PRINT_INSN_INFO, "dis_asm_memory_error",
> 	"dis_asm_read_memory", and "dis_asm_print_address", use
> 	"deprecated_tm_print_insn_info"
>
> Index: tui/ChangeLog
> 2003-04-28  Andrew Cagney  <cagney@redhat.com>
>
> 	* tuiDisassem.c (tui_disassemble): Use
> 	"deprecated_tm_print_insn_info" instead of TARGET_PRINT_INSN_INFO,
> 	add comment.