Re: [patch rfc] store_address -> store_unsigned_integer

[Andrew Cagney <ac131313 at redhat dot com>]

> Hello,
>
> This patch replaces store_address() with store_unsigned_integer().  A follow on patch would replace extract_address() with extract_unsigned_integer().
>
> Why?
>
> Because both extract_address() and store_address() are misnomers.  On the MIPS and any d10v like harvard architecture they do not and cannot do what they claim.  If the code really needs to extract or store an address then the recently added:
>     extract_typed_address()
>     store_typed_address()
> methods need be used (and core GDB does this).
>
> Baring comment (...), I'll look to commit this in a few days (and then follow up with the corresponding extract_address patch).

I've checked the non-doc part in ...

> 2003-05-08  Andrew Cagney  <cagney@redhat.com>
>
> 	* defs.h (store_address): Delete declaration.
> 	findvar.c (store_address): Delete function.
> 	* arm-tdep.c (arm_push_dummy_call): Replace store_address with
> 	store_unsigned_integer.
> 	* xstormy16-tdep.c (xstormy16_address_to_pointer): Ditto.
> 	* v850-tdep.c (v850_push_arguments): Ditto.
> 	* sparc-tdep.c (sparc_get_saved_register): Ditto.
> 	* sh-tdep.c (sh64_get_saved_register): Ditto.
> 	* rs6000-tdep.c (rs6000_push_arguments): Ditto.
> 	* ppc-sysv-tdep.c (ppc_sysv_abi_push_arguments): Ditto.
> 	* mips-tdep.c (mips_eabi_push_arguments): Ditto.
> 	(mips_get_saved_register): Ditto.
> 	* ia64-tdep.c (ia64_get_saved_register): Ditto.
> 	(find_func_descr, ia64_push_arguments): Ditto.
> 	* i386-tdep.c (i386_push_arguments): Ditto.
> 	* hpux-thread.c (hpux_thread_fetch_registers): Ditto.
> 	* frv-tdep.c (frv_push_arguments): Ditto.
> 	* frame.c (legacy_saved_regs_prev_register): Ditto.
> 	(deprecated_generic_get_saved_register): Ditto.
> 	* findvar.c (unsigned_address_to_pointer): Ditto.
> 	* dwarf2read.c (dwarf2_const_value): Ditto.
> 	* arm-linux-tdep.c (arm_linux_push_arguments): Ditto.
> 	* alpha-tdep.c (alpha_push_arguments): Ditto.

For the doco I'll update that (with extract_address) separatly.

Andrew