This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC/RFA/frame stuff] Fix build failure in alpha-osf1-tdep.c


> >I am not sure if it is really worth fixing this sort of thing now, or
> >worry about it later... You know the grand plan, so your call.
> 
> If the change is straight forward, might as well.  If it's a struggle, 
> don't bother - I'll be looking over the code anyway to see where there 
> are problems. 

Looking more closely, I think it's not worth bothering yet, because this
call actually hides a small cast from LONGEST to CORE_ADDR, which is not
fancied (such explicit casts are even flagged by the ARI, IIRC).

If I were to "fix" this, I would replace the call to read_memory_integer
by a call to read_memory_typed_address. But this does not have a frame
equivalent. Maybe that's something that we will have to add in the
future?

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]