This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: patch to convert_doublest_to_floatformat in doublest.c
- From: Kevin Buettner <kevinb at redhat dot com>
- To: "J. Johnston" <jjohnstn at redhat dot com>, gdb-patches at sources dot redhat dot com
- Date: Wed, 11 Jun 2003 14:19:55 -0700
- Subject: Re: RFA: patch to convert_doublest_to_floatformat in doublest.c
- References: <3EE62E90.1000806@redhat.com>
On Jun 10, 3:16pm, J. Johnston wrote:
> The old algorithm is correct for floating values whereby there are
> 32 or more mantissa bits. In such a case, we only can put 31 bits
> into the result. A simple test was added. The patch has been
> tested on the ia64 and x86.
I'm wondering about the test that you added. You say that the old
algorithm was correct for 32 or *more* mantissa bits. Yet the test
you added is as follows:
> + if (mant_bits == 32)
I'm wondering if this should instead be:
if (mant_bits >= 32)
?
Kevin