Re: [RFC/RFA] Per-objfile data mechanism

[Daniel Jacobowitz <drow at mvista dot com>]

On Tue, Jul 15, 2003 at 09:48:31AM -0700, David Carlton wrote:
> On Tue, 15 Jul 2003 12:17:29 -0400, Daniel Jacobowitz <drow@mvista.com> said:
> 
> > The concept is nice, but I share David's concern.
> 
> I'm not sure what my concern is; I'm just curious. :-) I guess my
> inchoate attitude (as an interested observer who has a patch waiting
> for approval that adds per-objfile data) is that I don't mind at all
> adding new data to every objfile: there just aren't enough of them to
> worry about.  The advantage of doing that as a member is that its
> existence is right there in objfiles.h for anybody to look at.  The
> advantage of Mark's mechanism is that, if the data is only used by
> one file, then you don't have to clutter objfiles.h with it.
> 
> I was also going to write, based on a cursory misreading of Mark's
> patch, that it simplified memory management in some circumstances, but
> now that I look at it more closely, I think I just misread the patch.
> (I may still be misreading the patch; my head is spinning with other
> things.)  Would it be possible/beneficial to modify the mechanism to
> provide an optional per-datum cleanup function as well?

Sure.  And that's the best reason I've heard so far for doing it this
way.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer