This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa] some -Wformat-nonliteral changes
- From: David Carlton <carlton at kealia dot com>
- To: Andrew Cagney <ac131313 at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 04 Aug 2003 10:14:38 -0700
- Subject: Re: [rfa] some -Wformat-nonliteral changes
- References: <yf2isphunls.fsf@hawaii.kealia.com> <3F2E6837.4010201@redhat.com>
On Mon, 04 Aug 2003 10:05:43 -0400, Andrew Cagney <ac131313@redhat.com> said:
> Insert expression of disbelief:
>> - internal_error ("Error converting character `%d' from `%s' to `%s' "
>> + internal_error (__FILE__, __LINE__,
>> + "Error converting character `%d' from `%s' to `%s' "
>> "character set: %s",
>> from_char, ci->from->name, ci->to->name,
>> safe_strerror (errno));
We can be pleased at GDB's robustness that this internal error doesn't
get triggered. :-)
> Yes, ok, and yes, the internal_error patch should go onto the
> branch.
Great; I've committed all of it to mainline, and the internal_error
part to the branch.
> Before reverting -Wformat-nonliteral, I'd like to see exactly what the
> damange is - it's clearly finding bugs.
Okay, but I'll continue to grumble... :-)
David Carlton
carlton@kealia.com