This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: trivial PATCH to dwarf2read.c:dwarf_attr_name


On Wed, 27 Aug 2003 10:46:42 -0400, Andrew Cagney <ac131313@redhat.com> wrote:

>> On Tue, 26 Aug 2003 23:56:42 -0400, Andrew Cagney <ac131313@redhat.com> wrote:
>>
>>>> I'm checking this in under the obvious rule; DW_AT_MIPS_linkage_name is
>>>> used on all targets.
>>>> 2003-08-26  Jason Merrill  <jason@redhat.com>
>>>> 	* dwarf2read.c (dwarf_attr_name): Move DW_AT_MIPS_linkage_name
>>>> 	case out of #ifdef MIPS block.

>>> Jason, exactly what prompted the change?  In particular which GCC?
>> I don't remember.  I think it's been in my local tree for years.  It's
>> quite likely that I just noticed it.
>
> Can you please find out.  There must be a stronger rationale then "it's
> been in my local tree for years".

The only rationale I have is that GCC emits DW_AT_MIPS_linkage_name on all
targets, so gdb should recognize it on all targets.

This isn't something that would affect normal operation--dwarf_attr_name is
only used by dump_die, which is only called when there's some sort of
internal error.  I probably just noticed this in a grep for
DW_AT_MIPS_linkage_name while I was working on something else.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]