Re: PATCH: correctly place new inclusions in includer's list

[Jim Blandy <jimb at redhat dot com>]

David Carlton <carlton@kealia.com> writes:

> On 22 Sep 2003 12:57:29 -0500, Jim Blandy <jimb@redhat.com> said:
> 
> > I think this would be good to include on the 6.0 branch; would that
> > be okay?
> 
> I've seen macrotab seg faults intermittently over the last few months;
> I've been too lazy to track them down (they're hard to reproduce, and
> I didn't know if it was something weird about my branch or a bug in
> mainline), but if this patch might fix them, and if it's as trivial as
> it seems, then putting it in 6.0 makes sense to me.

It's hard to see how this would fix any seg faults.  It just fixes
where in the list the traversal stops; but no matter where it stops,
the other loop conditions ensure that it stops in a structurally valid
state.

So I'd say the segfaults you've seen don't weigh for or against.