This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa:ppc64] Use target in convert_from_func_ptr_addr


On Oct 23,  5:02pm, Andrew Cagney wrote:

> If you want I can add a wrapper method, reducing the actual change to 
> just the modification of:
> 
> -    return read_memory_unsigned_integer (addr, 8);
> 
> to:
> 
> +	return get_target_memory_unsigned (targ, addr, 8);

That'd be great.  (With this change, consider it approved.)

> > Yes.  But what does this buy us?  I.e, what will we be able to do after
> > this patch that we couldn't do before?
> 
> The ability to apply this architecture method to an arbitrary target 
> instance?  Sorry, but I'm afraid that I'm missing something in your 
> question.

I'm trying to understand where you're going with these changes.  Do
you anticipate that this architecture method will ever be called
with anything other than current_target?  If so, then under what
circumstances?  Will a GDB user see enhanced functionality as a
result?

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]