This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC/RFA] find_pc_sect_psymtab(): symbol table not always complete


> > 2003-11-19  J. Brobecker  <brobecker@gnat.com>
> > 
> >         * symtab.c (find_pc_sect_psymtab): Refine the search for the
> >         partial symtab corresponding to the given PC address, taking
> >         into account the fact that the symbol table might be incomplete.
> 
> FWIW, this looks good to me, but I'd like another comment on the new
> test to the effect of, the find_pc_sect_psymtab call will always return
> the closest symbol below pc in tpst.  Threw me for a moment how you
> were just checking for the highest valued symbol.

Thanks for your feedback Daniel. I agree on that a comment is useful.
Here is a revised version of the patch. Is it better?

-- 
Joel

Attachment: symtab.c.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]