This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[PATCH] use "verbose" for notification of not running a test
- From: Fred Fish <fnf at public dot ninemoons dot com>
- To: gdb-patches at sources dot redhat dot com
- Cc: fnf at ninemoons dot com
- Date: Sat, 29 Nov 2003 15:24:54 -0700 (MST)
- Subject: [PATCH] use "verbose" for notification of not running a test
- Reply-to: fnf at ninemoons dot com
Other places in the testsuite where tests are not run based on the
target or it's capabilities use "verbose" to notify the user. The
suppression mechanisms are generally reserved for short circuiting
future tests when a failure of some kind is observed when attempting a
test.
2003-11-29 Fred Fish <fnf@redhat.com>
* gdb.asm/asm-source.exp: Use "verbose" when not running
assembly tests or not supporting multilib.
Index: gdb.asm/asm-source.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.44
diff -c -p -r1.44 asm-source.exp
*** gdb.asm/asm-source.exp 26 Nov 2003 01:17:16 -0000 1.44
--- gdb.asm/asm-source.exp 29 Nov 2003 22:22:01 -0000
*************** switch -glob -- [istarget] {
*** 111,117 ****
}
if { "${asm-arch}" == "" } {
! gdb_suppress_entire_file "Assembly source test -- not implemented for this target."
}
# On FreeBSD and NetBSD, crt1.o the final link will fail because of
--- 111,118 ----
}
if { "${asm-arch}" == "" } {
! verbose "Assembly source test -- not implemented for this target."
! return;
}
# On FreeBSD and NetBSD, crt1.o the final link will fail because of
*************** set dest [target_info name]
*** 134,140 ****
if [board_info $dest exists multilib_flags] {
set multilib_flags [board_info $dest multilib_flags]
if { "${multilib_flags}" != "" } {
! gdb_suppress_entire_file "Assembly source test -- multilibs not supported by this test."
return;
}
}
--- 135,141 ----
if [board_info $dest exists multilib_flags] {
set multilib_flags [board_info $dest multilib_flags]
if { "${multilib_flags}" != "" } {
! verbose "Assembly source test -- multilibs not supported by this test."
return;
}
}