This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Outwit compiler dead code elimination in break.exp test


Michael Elizabeth Chastain writes:
 > It works for me.  My before-and-after tests came out clean again; all
 > the copyright dates look good; and the comment about the separate file
 > is exactly what I wanted.
 > 
 > Endorsed for approval.
 > 
 > (I'm trying to come up with some word that means "I don't have approval
 > authority but I'll vouch for this patch" ... "endorsed"?  "recommended"?)
 > 

I can rubberstamp it. However Fred could self approve it too.

elena


 > Michael C
 > 
 > ===
 > 
 > 2003-12-07  Fred Fish  <fnf@redhat.com>
 > 
 > 	* gdb.base/break.c (marker1, marker2, marker3, marker4): Move
 > 	functions to break1.c and leave prototypes behind.  Add more
 > 	"set breakpoint NN here" comments.
 > 	* gdb.base/break1.c: New file.
 > 
 > 	* gdb.base/break.exp: Handle compiling test case from multiple
 > 	source files and change source file references as needed.
 > 	* gdb.base/completion.exp: Ditto.
 > 	* gdb.base/condbreak.exp: Ditto.
 > 	* gdb.base/define.exp: Ditto.
 > 	* gdb.base/ena-dis-br.exp: Ditto.
 > 	* gdb.base/info-proc.exp: Ditto.
 > 	* gdb.base/maint.exp: Ditto.
 > 	* gdb.base/until.exp: Ditto.
 > 
 > 	* gdb.base/condbreak.exp: Use bp_locationNN variables instead of
 > 	hardcoded line numbers.
 > 	* gdb.base/define.exp: Ditto.
 > 	* gdb.base/ena-dis-br.exp: Ditto.
 > 	* gdb.base/maint.exp: Ditto.
 > 	* gdb.base/until.exp: Ditto.
 > 
 > 	* gdb.base/completion.exp: Use "break1" for completion tests since
 > 	"break" is no longer a unique prefix.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]