Re: [patch/rfc] Fix inside entry func call

[Daniel Jacobowitz <drow at mvista dot com>]

On Mon, Feb 02, 2004 at 11:06:15PM -0500, Andrew Cagney wrote:
> Hello,
> 
> This, cleans up one part of a long dangling thread.  Per:
> http://sources.redhat.com/ml/gdb-patches/2003-11/msg00462.html
> This modifies the unwind code so that it uses the test:
> 
> +      && get_frame_func (this_frame) == entry_point_address ()
> 
> that that in place, the old inside_entry_func can be made static to 
> blockframe.c.  This should reduce Kevin's patch to just doco + frame.c 
> tweaks.
> 
> comments?

Please re-read that discussion.  Particularly:

  http://sources.redhat.com/ml/gdb-patches/2003-11/msg00459.html

in which I asked you to leave the call to inside_entry_func and change
its implementation.  You asked for other legitimate uses of this
function, and I gave you some.

> 	(get_prev_frame): Instead of inside_entry_func, call
> 	get_frame_func and entry_point_address.

I still object to this change.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer