This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa/testsuite] gdb1250.exp: make 'break abort' work with new pending breakpoints
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Michael Elizabeth Chastain <mec dot gnu at mindspring dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 9 Feb 2004 10:38:05 -0500
- Subject: Re: [rfa/testsuite] gdb1250.exp: make 'break abort' work with new pending breakpoints
- References: <20040209072340.665D84B104@berman.michael-chastain.com>
On Mon, Feb 09, 2004 at 02:23:40AM -0500, Michael Chastain wrote:
> This patch enhances gdb.base/gdb1250.exp so that it works with
> the new pending-breakpoint interface. This test wants to set a
> breakpoint on 'abort', which may be in a shared library.
>
> Of course it still works with the old 'just quietly set the breakpoint'
> interface.
>
> I tested on native i686-pc-linux-gnu, red hat 8.0, glibc 2.2.93-5-rh.
> I tested with gdb 6.0 and gdb HEAD, gcc 3.3.2, binutils 2.14 and
> binutils HEAD, dwarf-2 and stabs+. All the tests PASSed in all
> configurations.
>
> This test is sensitive to the version of binutils because binutils HEAD
> has a PLT optimization for shared library functions.
So it used to fail with binutils HEAD, right?
>
> Okay to commit?
This I'm not so sure about.
- Should there be a version of gdb_breakpoint that answers yes to the
pending question?
- If so, should runto use it? Or should there be a version of runto
that does?
I think the latter might be best but I don't know what to call them.
Maybe:
gdb_breakpoint_allow_pending
runto_allow_pending
> 2004-02-09 Michael Chastain <mec.gnu@mindspring.com>
>
> * gdb.base/gdb1250.exp: Improve 'break abort' to work with new
> pending-breakpoint user interface.
Fixing this is great though!
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer