This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Fix several problems with the gdb.arch/gdb1291.exp test
- From: Fred Fish <fnf at ninemoons dot com>
- To: Daniel Jacobowitz <drow at mvista dot com>, fnf at redhat dot com
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 10 Feb 2004 18:28:30 -0700
- Subject: Re: [RFA] Fix several problems with the gdb.arch/gdb1291.exp test
- References: <200402101807.37718.fnf@ninemoons.com> <20040211011715.GA11122@nevyn.them.org>
- Reply-to: fnf at redhat dot com
On Tuesday 10 February 2004 18:17, Daniel Jacobowitz wrote:
> Sorry, not OK. There are at least three problems:
All excellent points, as usual. Good example of why it's important to
have reviews of all patches. :-)
> - You've added a kfail pattern for PR 1291 that doesn't match the
> description in the PR; the less than 256 bytes case shouldn't
> be a kfail.
Another oops. That piece of the cloned test wasn't meant to be included.
> I recommend writing the whole test in assembly instead; this is
> gdb.arch, after all. We don't want to be sensitive to GCC bugs.
That sounds like the best solution.
Back to the drawing board...
-Fred