This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: make inferior calls work on ia64 even when syscall is pending
- From: Mark Kettenis <kettenis at chello dot nl>
- To: davidm at hpl dot hp dot com
- Cc: davidm at hpl dot hp dot com, kevinb at redhat dot com, jjohnstn at redhat dot com, gdb-patches at sources dot redhat dot com
- Date: Fri, 13 Feb 2004 15:58:04 +0100 (CET)
- Subject: Re: make inferior calls work on ia64 even when syscall is pending
- References: <16371.12104.503371.251351@napali.hpl.hp.com><200312312333.hBVNXNvg016633@elgar.kettenis.dyndns.org> <16428.9442.113820.725379@napali.hpl.hp.com>
From: David Mosberger <davidm@napali.hpl.hp.com>
Date: Thu, 12 Feb 2004 17:14:10 -0800
>>>>> On Thu, 1 Jan 2004 00:33:23 +0100 (CET), Mark Kettenis <kettenis@chello.nl> said:
Mark> From: David Mosberger <davidm@napali.hpl.hp.com> Date: Wed,
Mark> 31 Dec 2003 12:19:20 -0800
Mark> If the gdb patch looks OK, please check it in.
Mark> David, there are two issues with the patch:
Mark> * I suspect that this approach is Linux-specific. If so, you
Mark> really shouldn't be adding this bit of code to the generic
Mark> ia64_write_pc(). Instead you should create a Linux-specific
Mark> ia64_linux_write_pc() and put it in ia64-linux-tdep.c; you'll
Mark> probably want to call the generic ia64_write_pc() from there.
Mark> Then you must hook in the Linux-specific version if the OSABI
Mark> is GDB_OSABI_LINUX.
Mark> * You should use write_register_pid() instead of
Mark> write_register().
How about the attached patch?
Looks good, except for the "extern" function proptotypes. But I guess
we can't blame you for following the bad example set by ia64-tdep.c.
Kevin, can you approve this patch and create an ia64-tdep.h file with
the function prototypes afterwards?
David, You're not mentioned in the MAINTAINERS file. Do you have a
valid FSF copyright assignment for GDB?
Mark