This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Fix compilation of tui/tui.c
Date: Sat, 28 Feb 2004 10:20:55 -0500
From: Andrew Cagney <cagney@gnu.org>
> Ouch. We have serious portability problems with the TUI. We should
> either disable it again before the 6.1 release, or be prepared to
> release 6.1.1 if any build problems come up. I'm sure we'll see build
> problems on many systems that we don't regularly test.
>
> Anyway, I committed the attached such that FreeBSD (and probably the
> other BSD's work again/.
It works on my bsd system (how do you think I was testing it)?
I didn't check on OpenBSD or NetBSD, but I supposed they would suffer
from the same problems as my FreeBSD-system.
What portability problem.
The TUI code is including header files and using library functions
that we've never used before in GDB. We've already seen the fall-out
from this on HP-UX and Solaris, and now on FreeBSD. I'm just afraid
that more of these problems will surface when somebody tries to build
GDB other platforms.
Is there a reason for changing "" to <>, it breaks some of GDB's
scripts.
I changed because we seem to use <> everywhere else in GDB for the
readline includes, e.g. event-top.c, completer.c. I think it's good
to be consistent; you get less surprises that way.
Mark