Re: [RFA/dwarf-2] Fix for the null record problem

[Joel Brobecker <brobecker at gnat dot com>]

Hello Jim,

Good catch about the is_declaration() case.

> Joel, how about dropping the DW_AT_specification test from
> die_is_declaration, and then using it in the new test in your patch?

Based on Jason's answer, it looks like the DW_AT_specification check
was indeed necessary. I have added a comment in that respect in the
little cleanup patch you suggested earlier. See:

    http://sources.redhat.com/ml/gdb-patches/2004-04/msg00325.html

Here a new version of the initial patch that follows your suggestion
of using die_is_declaration(). It's indeed more correct, and even
easier to read.

2004-04-15  Joel Brobecker  <brobecker@gnat.com>

        * dwarf2read.c (read_structure_scope): Identify stub types
        using die_is_declaration() only.

Tested on x86-linux, no regression.
OK to apply?

Thanks,
-- 
Joel

Attachment: dwarf2read.c.null-record.diff
Description: Text document