This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Oops, missed the comment refering to the removed function. Updated patch attached. ChangeLog unchanged from below. Ok to apply? On Mon, 19 Apr 2004, Brian Ford wrote: > On Mon, 19 Apr 2004, Mark Kettenis wrote: > > > Hmm. I very much agree with what Brian wrote in his follow-up > > messages. I think DJGPP is doing the right thing using the SVR4 > > scheme for DWARF2 while staying backwards compatible for stabs. I'd > > advise him to do the same for cygwin. > > Ok, do I need approval to revert my own patch ;-) ? > > 2004-04-19 Brian Ford <ford@vss.fsi.com> > > Revert 2004-04-16 change. > * i386-tdep.c (i386_gdbarch_init): Fix comment typos. > (i386_coff_init_abi): Remove. > * i386-tdep.h (i386_coff_init_abi): Remove. > * i386-cygwin-tdep.c (i386_cygwin_init_abi): Remove call to above. > > > If i386_coff_init_abi will be gone, the comments aren't contradictiory > > anymore. > > Not exactly, as Eli pointed out before, both of the following will be > false for DJGPP and Cygwin/Mingw: > > Currently, each GCC i386 target always uses the same register > numbering scheme across all its supported debugging formats > i.e. SDB (COFF), stabs and DWARF 2. This is because > gcc/sdbout.c, gcc/dbxout.c and gcc/dwarf2out.c all use the > DBX_REGISTER_NUMBER macro which is defined by each target's > respective config header in a manner independent of the requested > output debugging format. > > > On Mon, 19 Apr 2004 at 08:50:59 +0200, Eli Zaretskii wrote: > > > >> On Sun, 18 Apr 2004 20:38:38 +0200 (CEST), Mark Kettenis wrote: > >> > >>>+ floating-point registers, and are implemented by the attays > >> ^^^^^^ > >> A typo. > > > > I though I'd fixed that one :-(. > > and another: > > implemented in dbx64_register_map, and us used for AMD64; see > ^^ > both of which are fixed in the attached patch. Ok to apply? -- Brian Ford Senior Realtime Software Engineer VITAL - Visual Simulation Systems FlightSafety International Phone: 314-551-8460 Fax: 314-551-8444
Attachment:
cygwin_revert_dwarf_regnum.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |