This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch/rfa/hppa] Use frame pointer for unwinding
- From: Mark Kettenis <kettenis at chello dot nl>
- To: randolph at tausq dot org
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sun, 16 May 2004 12:36:20 +0200 (CEST)
- Subject: Re: [patch/rfa/hppa] Use frame pointer for unwinding
- References: <20040516020703.GZ566@tausq.org>
Date: Sat, 15 May 2004 19:07:03 -0700
From: Randolph Chung <randolph@tausq.org>
- if (frame_pc_unwind (next_frame) >= prologue_end)
+ if (get_frame_type (next_frame) == NORMAL_FRAME
+ && u->Save_SP
+ && (fp = frame_unwind_register_unsigned (next_frame, HPPA_FP_REGNUM)))
+ {
+ cache->base = fp;
Randolph, this patch has a major style problem: assignments within an
if-statement are frowned upon. Can you fix that?
Thanks,
Mark