This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/RFC] New command: ``start''


> Date: Tue, 18 May 2004 10:05:17 -0700
> From: Joel Brobecker <brobecker@gnat.com>
> 
> Just one additional comment, that may not be obvious: In Ada, the name
> of the main procedure is not specified by Ada, it's up to the user to
> choose it. That means that the name of that main procedure depends on
> the program. When Ada-support is activated, we'll implement our own
> main_procedure_name method that will dig out that name from the
> executable. JIC.

Understood.

> > Please use "C@t{++}" instead of "C++", the former looks prettier in
> > print.
> 
> Fixed.

Thanks, but there's still one place where "C++" is used ;-)

> I tried to make it more explanatory by explaining what happens during
> the elaboration (some code is run before the main procedure is called),
> and also by providing an example using C++ constructors.

Okay, this is much more clear now.  Perhaps it would be useful to
mention the term ``startup code'' there?

> > You mean, if you type "run" thereafter, it will reuse the arguments
> > you type for the "start" command?  If so, we should reword this text
> > to make that more clear.  ``Directly passed'' is confusing, since
> > nothing is really passed anywhere.
> 
> I have reworked the documentation. Is it better?

It's much better, thanks.  However, I understand that the same
arguments will be reused later if the user invokes "run", is that
true?  If so, I think we should mention that.

> +@table @code
> +@kindex start

I think an additional index entry here saying

  @cindex run to main procedure

would help.

Otherwise, the documentation patch is approved; thanks.

For the code patch, please wait for the responsible person(s) to give
their final blessing.  (Hmm... who is that in this case? MAINTAINERS
says "Blanket Write Privs Maintainers".  Andrew?)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]