This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Small problem with Remote Protocol register fetching.
- From: Andrew Cagney <cagney at gnu dot org>
- To: Steven Johnson <sjohnson at neurizon dot net>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 15 Jun 2004 11:26:03 -0400
- Subject: Re: Small problem with Remote Protocol register fetching.
- References: <40CEB176.1040904@neurizon.net>
Registers in the remote protocol are Hex Encoded. Hex encoded values can have (as far as I can tell, valid values of '0'-'9','a'-'f','A'-'F' and ('x' for registers). the problem is that register packets that have an upper case 'A'-'F' in the first location are junked as being bad packets, when their is nothing wrong. And then GDB ends up in an infinite comms loop, trying to recover.
The attached patch allows Hex Encoded values to include upper case letters (in the case of fetching registers) without causing the packet handling to fail.
I wasnt sure if 'X' should also be allowable, seems like it should, but i dont know for sure, so havent changed it.
Hmm, the code's been that way since, well, forever and no one noticed!
Perhaphs we should just clarify the spec and define it as lowercase
@sc{hex}.
Andrew