This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] mips-irix SEGV: long doubles are 128 bits long on IRIX


On Wed, Jul 21, 2004 at 04:33:10PM -0700, Joel Brobecker wrote:
> > > 2004-07-21  Joel Brobecker  <brobecker@gnat.com>
> > > 
> > >         * mips-irix-tdep.c: #include "mips-tdep.h".
> > >         (mips_irix_init_abi): Set size of long double to 128 bits
> > >         for N32 and N64 ABIs.
> > >         * Makefile.in (mips-irix-tdep.o): Add dependency on mips-tdep.h.
> > > 
> > > Tested on mips-irix, fixes the problem above and many other FAILs.
> > > OK to commit?
> > 
> > I can't find the right CVS tree at the moment to double-check, but I
> > think this is true for mips-linux and embedded MIPS using N32/N64 also.
> 
> Do you think this is going to affect this patch? Or are you suggesting
> that we should fix mips-linux and embedded N32/N64 as well?

I'm suggesting that this change belongs in mips-tdep.c rather than in
an OSABI handler.  Unfortunately I'm not set up to test on mips64-linux
at the moment (and results were pretty dismal, though not quite as bad
as Irix).

-- 
Daniel Jacobowitz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]