This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA/RFC: Change Sparc64 gdb.asm tests to use -gdwarf2 instead of -gstabs


All right!  This patch is approved.

> AFAIK there is no such bug report.  Although there is a related one 
> about the generation of aligned and unaligned relocs for the Sparc.

Then the test can continue to FAIL until someone files a bug report
for it, or just fixes it, or maybe makes it UNSUPPORTED.  That's okay.

> OK I ran those tests, although I changed the flags to be "-gdwarf2" and 
> "-gstabs+".  I also added "gdb.asm/asm-source.exp" to the command lines, 
> since I assumed that it was OK to just run the assembler tests.  The 
> patch does not affect any other part of the GDB testsuite.

Err right, my sample code was bad.  Yeah, it's okay to just test
asm-source.exp.

> I ran the tests on an x86 native host and a Sparc64 native host, just to 
> make sure that the default selection code worked as well.  There was 
> only one combination that produced any failures:
>
>    Sparc64 native with -gstabs+

Beautiful, that's what I'm looking for.

Now the next poor hacker who ventures into asm-source.exp will have
something to read when they say "what is this ... let me check the
mailing list archives ...".

Michael C

===

2004-07-26  Nick Clifton  <nickc@redhat.com>

	* gdb.asm/asm-source.exp (debug-flags): New variable.  If a
	known good default value for a specific architecture is
	available then set it to that value.  Otherwise default to the
	-gstabs switch.  Remove the -g... switches from the asm-flags
	variable.  Allow the target board info to override the value if
	it wants to.  Pass the switch on the assembler command line.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]