Re: [patch/testsuite] lib/gdb.exp: native tcl gdb_get_line_number

[Michael Chastain <mec dot gnu at mindspring dot com>]

Mark Kettenis <kettenis@chello.nl> wrote:
> This causes problems if you configure using a relative pathname, i.e.
>
>   ../src/configure --enable-gdb-build-warnings=,-Werror

Oof.  I forgot all about relative pathnames.

> The attached patch fixes things for me, but can somebody please check
> whether i've escaped the dot correctly?

I'm going to think about this problem a bit.  I don't really like that
compatibility kludge in the first place, and I'd rather bust some heads
in the callers and de-kludge this rather then en-kludge it some more.
So this patch is not approved.  (If I don't get the problem fixed pretty
quick then I'll have to accept it though).

Which files are causing problems on your system?  On my system,
the intersection between gdb_get_line_number and ${srcfile*} with
a "/" in them is:

  gdb.cp/ctti.exp
  gdb.cp/m-static.exp

So I would have to change two callers.

In the long run I want to go further and change all the callers to
explicitly specify a filename and then kill off the kludge.
But that's not suitable for right now.

Michael C