Re: [PATCH] i386bsd-nat.c tweak

[Robert Millan <rmh at debian dot org>]

On Thu, Aug 12, 2004 at 10:55:23AM +0200, Mark Kettenis wrote:
> 
>    This disables the code below on GNU/kFreeBSD, but it's still enabled in
>    FreeBSD 4.x or later.
> 
> Yes indeed.
> 
> [...]
> 
>    Build on GNU/kFreeBSD still works, but it might be that keeping
>    SC_REG_OFFSET undefined results in a weird runtime bug that will be
>    difficult to trace, so I'd really like to be sure this part is ok.
> 
> It will be caught on normal FreeBSD.

We have this check:

  #if defined (__FreeBSD_version) && __FreeBSD_version >= 400011
  #define SC_REG_OFFSET i386fbsd4_sc_reg_offset

This ensures that SC_REG_OFFSET is defined for either 4.x or 5.x (i.e. any
non-obsolete version of FreeBSD).  If not defining it triggers a bug, how
can it be caught on normal FreeBSD, if that situation never happens?

Perhaps what you want is something like this?:

  #if defined (__FreeBSD_version) && __FreeBSD_version >= 400011 \
  	__FreeBSD_version < 500000
  #define SC_REG_OFFSET i386fbsd4_sc_reg_offset

Then i386fbsd4_sc_reg_offset would be for 4.x only, which seems like the
intended result.  Is that it?

-- 
Robert Millan

(Debra and Ian) (Gnu's Not (UNiplexed Information and Computing System))/\
(kernel of *(Berkeley Software Distribution))