This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/RFA] PR gdb/648


Thanks for the revisions!

Any reason read_array_ordering can't return 'enum
dwarf_array_dim_ordering' instead of 'int'?

The special case for GNU F77 needs a comment --- just explaining that
F77 does things backwards as of Aug 2004, etc. etc.  Basically what
you said in your original post, explaining why the special case was
necessary.

With those changes, the dwarf2read.c portions of this change are
approved.  So I think the eval.c stuff is all that's left for someone
to review.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]