This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch/testsuite] whatis.c, whatis.exp: remove "signed char" kludge


This patch removes a workaround for compilers that don't support
"signed char".  "signed char" has been part of Ansi C since 1989.

Tested on:

  native i686-pc-linux-gnu, gcc 2.95.3 3.3.4 3.4.1, dwarf-2 stabs+
  native hppa2.0w-hp-hpux11.11, hp ansi c B.11.11.28706.gp
  native hppa2.0w-hp-hpux11.11, gcc 3.3.4

I am committing this now.

2004-08-23  Michael Chastain  <mec.gnu@mindspring.com>

	* gdb.base/whatis.c: Remove conditional disabling of "signed".
	* gdb.base/whatis.exp: Remove signed_keyword_not_used.

Index: gdb.base/whatis.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/whatis.c,v
retrieving revision 1.2
diff -c -3 -p -r1.2 whatis.c
*** gdb.base/whatis.c	23 Aug 2004 12:28:23 -0000	1.2
--- gdb.base/whatis.c	23 Aug 2004 13:00:35 -0000
***************
*** 1,6 ****
  /* This test program is part of GDB, the GNU debugger.
  
!    Copyright 1992, 1993, 1994, 1997, 1999
     Free Software Foundation, Inc.
  
     This program is free software; you can redistribute it and/or modify
--- 1,6 ----
  /* This test program is part of GDB, the GNU debugger.
  
!    Copyright 1992, 1993, 1994, 1997, 1999, 2004
     Free Software Foundation, Inc.
  
     This program is free software; you can redistribute it and/or modify
***************
*** 27,36 ****
   *	First the basic C types.
   */
  
- #if !(defined (__STDC__) || defined (_AIX))
- #define signed  /**/
- #endif
- 
  char		v_char;
  signed char	v_signed_char;
  unsigned char	v_unsigned_char;
--- 27,32 ----
Index: gdb.base/whatis.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/whatis.exp,v
retrieving revision 1.5
diff -c -3 -p -r1.5 whatis.exp
*** gdb.base/whatis.exp	4 Jan 2003 22:37:49 -0000	1.5
--- gdb.base/whatis.exp	23 Aug 2004 13:00:35 -0000
***************
*** 1,5 ****
! # Copyright 1988, 1990, 1991, 1992, 1994, 1995, 1996, 1997, 1999, 2002, 2003
! # Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,5 ----
! # Copyright 1988, 1990, 1991, 1992, 1994, 1995, 1996, 1997, 1999, 2002,
! # 2003, 2004 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
***************
*** 15,23 ****
  # along with this program; if not, write to the Free Software
  # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  
  
- # Please email any bugs, comments, and/or additions to this file to:
- # bug-gdb@prep.ai.mit.edu
- 
  # This file was written by Rob Savoye. (rob@cygnus.com)
  
  if $tracelevel {
--- 15,20 ----
*************** gdb_test "whatis v_char" \
*** 75,93 ****
      "type = (unsigned char|char)" \
      "whatis char"
  
- # If we did not use the signed keyword when compiling the file, don't
- # expect GDB to know that char is signed.
- if { $hp_cc_compiler || $hp_aCC_compiler } {
-     set signed_keyword_not_used 1
- }
- if $signed_keyword_not_used then {
-     set signed_char "char"
- } else {
-     set signed_char "signed char"
- }
  if {!$gcc_compiled} then { setup_xfail "mips-sgi-irix*" }
  gdb_test "whatis v_signed_char" \
!     "type = $signed_char" \
      "whatis signed char"
  
  gdb_test "whatis v_unsigned_char" \
--- 72,80 ----
      "type = (unsigned char|char)" \
      "whatis char"
  
  if {!$gcc_compiled} then { setup_xfail "mips-sgi-irix*" }
  gdb_test "whatis v_signed_char" \
!     "type = (signed char|char)" \
      "whatis signed char"
  
  gdb_test "whatis v_unsigned_char" \


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]