This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC/RFA] target.c: Check current_target in target_resize_to_sections
- From: "Nathan J. Williams" <nathanw at wasabisystems dot com>
- To: Andrew Cagney <cagney at gnu dot org>
- Cc: gdb-patches at sources dot redhat dot com
- Date: 27 Aug 2004 10:57:44 -0400
- Subject: Re: [RFC/RFA] target.c: Check current_target in target_resize_to_sections
- Organization: Wasabi Systems, Inc.
- References: <mtuy8k3eytj.fsf@contents-vnder-pressvre.mit.edu><412E5516.6050209@gnu.org>
Andrew Cagney <cagney@gnu.org> writes:
> > 2004-08-25 Nathan J. Williams <nathanw@wasabisystems.com>
> > * target.c (target_resize_to_sections): Check
> > current_target.to_sections for an old value when updating.
>
> Can you just add some sort of brief comment noting why current_target
> also needs to be checked. With that it's ok (but post the revised
> patch when committing).
Sure. Should I add the comment to the ChangeLog, the code, or both?
(The code already says what it's trying to do by updating all this
stuff, and while it's not obvious when something like current_target
is missing, it's pretty obvious when it's there).
- Nathan